Patch compiler error when building using nvcc #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
reviewed
Oct 21, 2019
include/fmt/core.h
Outdated
| @@ -58,10 +58,12 @@ | |||
| // Check if relaxed C++14 constexpr is supported. | |||
| // GCC doesn't allow throw in constexpr until version 6 (bug 67371). | |||
| #ifndef FMT_USE_CONSTEXPR | |||
| #if !(defined(__NVCC__) || defined(__CUDACC__)) | |||
There was a problem hiding this comment.
Is it necessary to check both __NVCC__ and __CUDACC__? Can one be set and another not?
There was a problem hiding this comment.
It is not necessary as __CUDACC__ can be considered a subset of __NVCC__. I'll remove the __CUDACC__ check: https://docs.nvidia.com/cuda/cuda-compiler-driver-nvcc/index.html#nvcc-identification-macro
If you compile using `nvcc` and pass the option `--expt-relaxed-constexpr` it will crash with an internal compiler error. This modification prevents using `constexpr` in `fmtlib` when compiling using `nvcc` and prevents the crash.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you compile using
nvccand pass the option--expt-relaxed-constexprit will crash with an internal compiler error. This modification prevents usingconstexprinfmtlibwhen compiling usingnvccand prevents the crash.To clarify, this seems to be necessary on CUDA 10 with
gcc(5->7)as the host compiler (everygccversion I tested). I did not have the chance to validate if other CUDA versions suffer from this same issue.I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.