Fix clang -Wsign-conversion warning in grisu_count_digits. #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grisu_count_digits is only used by grisu_gen_digits, which assigns the unsigned result to a (signed) int. Although grisu_count_digits always returns a positive integer this keeps its return type in sync with the type its result is assigned to.
|
Thanks! |
sthagen
added a commit
to sthagen/fmtlib-fmt
that referenced
this pull request
Mar 4, 2020
Fix clang -Wsign-conversion warning in grisu_count_digits. (fmtlib#1573)
teajay-fr
pushed a commit
to teajay-fr/fmt
that referenced
this pull request
Mar 18, 2020
grisu_count_digits is only used by grisu_gen_digits, which assigns the unsigned result to a (signed) int. Although grisu_count_digits always returns a positive integer this keeps its return type in sync with the type its result is assigned to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grisu_count_digits is only used by grisu_gen_digits, which assigns the unsigned result to a (signed) int.
Although grisu_count_digits always returns a positive integer this keeps its return type in sync with the type its result is assigned to.