fix interaction of space flag and '+' flag, as well as '-' flag and '… #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimathia
commented
May 16, 2020
| @@ -405,7 +405,9 @@ void basic_printf_context<OutputIt, Char>::parse_flags(format_specs& specs, | |||
| specs.fill[0] = '0'; | |||
| break; | |||
| case ' ': | |||
| specs.sign = sign::space; | |||
| if (specs.sign != sign::plus) { | |||
There was a problem hiding this comment.
from the opengroup description: "This means that if the <space> and + flags both appear, the flag shall be ignored."
rimathia
commented
May 16, 2020
| specs.align = align::numeric; | ||
| else | ||
| specs.fill[0] = ' '; // Ignore '0' flag for non-numeric types. | ||
| specs.fill[0] = ' '; // Ignore '0' flag for non-numeric types or if '-' | ||
| // flag is also present. |
There was a problem hiding this comment.
opengroup description: "If the 0 and - flags both appear, the 0 flag is ignored."
|
Hi, since the behaviour changes implemented here seem pretty clearly in line with the opengroup description of the printf familiy I have skipped opening an issue. |
|
This is great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…0' flag
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.