visual studio 2019 gives error C2049 #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cannot be reopened as inline) when compiling fmt with /clr)
|
Thanks |
|
thanks to you for wonderful fmt! |
|
Thanks for the fix, this has been bugging us for quite a while now. 🥳 |
vadz
added a commit
to vadz/fmt
that referenced
this pull request
Mar 15, 2021
Since the changes of 1305cbe (Fix MSVC2019 error C2049 when compiling with /clr (fmtlib#1897), 2020-09-23), compiling fmt with MSVS 2019 resulted in fmt\include\fmt\core.h(180,32): warning C4668: '_MANAGED' is not defined as a preprocessor macro, replacing with '0' for '#if/#elif'. when the (disabled by default) warning C4668 was enabled. Fix this simply by checking if _MANAGED is defined before testing it.
vitaut
pushed a commit
that referenced
this pull request
Mar 17, 2021
Since the changes of 1305cbe (Fix MSVC2019 error C2049 when compiling with /clr (#1897), 2020-09-23), compiling fmt with MSVS 2019 resulted in fmt\include\fmt\core.h(180,32): warning C4668: '_MANAGED' is not defined as a preprocessor macro, replacing with '0' for '#if/#elif'. when the (disabled by default) warning C4668 was enabled. Fix this simply by checking if _MANAGED is defined before testing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
visual studio 2019 gives error C2049 ('fmt::v7': non-inline namespace cannot be reopened as inline) when compiling fmt with /clr)
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.