Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename all shadowed types and variables and enable Wshadow when in pedantic mode #1965

Merged
merged 2 commits into from
Nov 3, 2020
Merged

Rename all shadowed types and variables and enable Wshadow when in pedantic mode #1965

merged 2 commits into from
Nov 3, 2020

Commits on Nov 3, 2020

  1. 🎨 🐛 Rename all shadowed types and variables

    @jgopel
    jgopel committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    a323649 View commit details
    Browse the repository at this point in the history

  2. 🆕 Enable -Wshadow in pedantic mode 

    Problem:
- All `-Wshadow` warnings are fixed but there is nothing stopping them
  from being reintroduced.

Solution:
- Fail pedantic builds on `-Wshadow` warnings. This allows CI to prevent
  reoccurrence of the warning.

Notes:
- Not enabling `-Wshadow` for gcc versions 4 or lower because the
  warning is much more aggressive there to the point that it's mostly
  just noise.
    @jgopel
    jgopel committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    82f6af4 View commit details
    Browse the repository at this point in the history