Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 [ci] Specify the exact version of clang to use #1991

Merged
merged 1 commit into from
Nov 8, 2020

Conversation

jgopel
Copy link
Contributor

@jgopel jgopel commented Nov 7, 2020

Problem:

  • The version of clang to use is specified only as clang++. This is
    inconsistent with the specifications for gcc and exposed to unexpected
    failure if the default changes.

Solution:

  • Specify the exact version of clang to use. I chose clang++-9 as that
    is the version that clang++ is currently resolving to.

I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.

@jgopel jgopel changed the title 🎨 Specify the exact version of clang to use 🎨 [ci] Specify the exact version of clang to use Nov 7, 2020
Problem:
- The version of clang to use is specified only as `clang++`. This is
  inconsistent with the specifications for gcc and exposed to unexpected
  failure if the default changes.

Solution:
- Specify the exact version of clang to use. I chose `clang++-9` as that
  is the version that `clang++` is currently resolving to.
@vitaut vitaut merged commit b3ab0bc into fmtlib:master Nov 8, 2020
@vitaut
Copy link
Contributor

vitaut commented Nov 8, 2020

Good idea, thanks!

@jgopel jgopel deleted the specify-clang-version branch November 14, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants