Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MS Visual Studio "/Zc:wchar_t-" compiler parameter support added #214

Merged
merged 1 commit into from
Oct 25, 2015
Merged

MS Visual Studio "/Zc:wchar_t-" compiler parameter support added #214

merged 1 commit into from
Oct 25, 2015

Conversation

slavanap
Copy link
Contributor

If /Zc:wchar_t- compiler parameter is specified, then wchar_t is defined as
typedef unsigned short wchar_t;
Thus, this leads to conflict in template definition in format.h

You can verify it in any Visual Studio project with spdlog with

set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /Zc:wchar_t-")

reference: https://msdn.microsoft.com/ru-ru/library/dh8che7s.aspx

vitaut added a commit that referenced this pull request Oct 25, 2015
MS Visual Studio "/Zc:wchar_t-" compiler parameter support added
@vitaut vitaut merged commit 716ab04 into fmtlib:master Oct 25, 2015
@vitaut
Copy link
Contributor

vitaut commented Oct 25, 2015

Merged with a minor change in acfa858 (without this change unsigned short values would be formatted as characters). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants