Print error message in FMT_THROW when exception is disabled #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiahao XU <[email protected]>
NobodyXu
changed the title
|
Thank you! |
sthagen
added a commit
to sthagen/fmtlib-fmt
that referenced
this pull request
Feb 24, 2021
Print x.what() of FMT_THROW when exception is disabled (fmtlib#2145)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if exception is disabled, an error in
fmtwill result a termination viaFMT_ASSERT, but there is no error message printed onstderr, so it can be a little bit confusing for the user on why the program failed.This PR modifies
FMT_THROWto passexception.what()toFMT_ASSERTas the error message.Although it doesn't provide more information which part of format string caused the error, it is better than printing no error message at all.
Signed-off-by: Jiahao XU [email protected]
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.