Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C++17 build #2192

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Fix C++17 build #2192

merged 1 commit into from
Mar 26, 2021

Conversation

phprus
Copy link
Contributor

@phprus phprus commented Mar 25, 2021

  • Fix C++17 Visual Studio builds.
  • Use C++17 for windows-2019 builds.
  • Removed options for unsupported compiler (MSVC11).
  • Removed options, not needed after enabling C++11+ features in gmock/gtest.

I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.

Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. In general looks good but let's keep the number of configurations manageable.

.github/workflows/windows.yml Show resolved Hide resolved
- Fix C++17 Visual Studio builds.
- Use C++17 for `windows-2019` builds.
- Removed options for unsupported compiler (MSVC11).
- Removed options, not needed after enabling C++11+ features in gmock/gtest.
@phprus phprus requested a review from vitaut March 26, 2021 11:03
@vitaut vitaut merged commit 4dc7170 into fmtlib:master Mar 26, 2021
@vitaut
Copy link
Contributor

vitaut commented Mar 26, 2021

Thank you!

sthagen added a commit to sthagen/fmtlib-fmt that referenced this pull request Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants