Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux CI config improvements #2217

Merged
merged 4 commits into from
Apr 10, 2021

Conversation

alexezeder
Copy link
Contributor

@alexezeder alexezeder commented Apr 8, 2021

Some points for this PR:

  • Clang 9 C++11 build here:
    - cxx: clang++-9
    std: 11
    os: ubuntu-18.04

    was implicitly covered by matrix. I removed those lines, but that change does nothing for the Clang 9 C++11 build, it works as before.
  • Build type was not specified for some builds, like:
    - cxx: g++-10
    std: 17
    os: ubuntu-18.04

    so it's not passed to CMake correctly, this led to messages like this:
    CMake Error: Invalid value used with --config
    
  • Clang 11 C++20 build added since it was welcomed here.
  • Clang 11 C++20 with LLVM libc++ build added. Thanks to this additional check, I found 2 problems, which are fixed in this PR:
    • lack of CXXFLAGS passing in find-package-test, thus -stdlib=libc++ flag was ignored, and an incorrect standard library was used, error log;
    • lack of <array> header include in compile-test, I fixed it by using a C-style array instead of std::array, error log.

for g++-8 C++14, g++10 C++17, g++10 C++20
 * find-package-test fixed by passing CXX_FLAGS, i.e. -stdlib=libc++
 * std::array usage in compile-test.cc replaced with plain array, because
   <array> header was not included
@vitaut vitaut merged commit b441532 into fmtlib:master Apr 10, 2021
@vitaut
Copy link
Contributor

vitaut commented Apr 10, 2021

Looks great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants