Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Visual Studio warning #2290

Merged
merged 1 commit into from
May 16, 2021
Merged

Fix Visual Studio warning #2290

merged 1 commit into from
May 16, 2021

Conversation

ilmai
Copy link
Contributor

@ilmai ilmai commented May 15, 2021

Visual Studio was complaining about unreachable code, presumably because vwindows_error was throwing the std::system_error instead of returning. Not 100% confident this is the correct fix, but quickly taking a look at how the function is used, this seems like the intended behavior.

@vitaut vitaut merged commit 0763d8c into fmtlib:master May 16, 2021
@vitaut
Copy link
Contributor

vitaut commented May 16, 2021

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants