FMT_USE_FCNTL can be predefined #2572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'os.h' accepts a predefined FMT_USE_FCNTL override so using FMT with e.g. the NXP toolchain for ARM (e.g. for FreeRTOS) does not have a fcntl() call, but the detection routine does not detect this correctly.
|
See issue #2570 |
phprus
reviewed
Oct 28, 2021
| # if (FMT_HAS_INCLUDE(<fcntl.h>) || defined(__APPLE__) || \ | ||
| defined(__linux__)) && \ | ||
| (!defined(WINAPI_FAMILY) || (WINAPI_FAMILY == WINAPI_FAMILY_DESKTOP_APP)) | ||
| # i nclude <fcntl.h> // for O_RDONLY |
There was a problem hiding this comment.
Unexpected space in "include".
There was a problem hiding this comment.
Sorry for that, I'll be more careful next time.
|
oh, sorry, I'll do that again. |
|
Closing this PR and opening the new one was unnecessary. You could just change the line with this |
|
This was my very first commit/pull request ever, so I am glad I managed it at all 😸. I'll do better next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'os.h' accepts a predefined FMT_USE_FCNTL override so using FMT with e.g. the NXP toolchain for ARM (e.g. for FreeRTOS) does not have a fcntl() call, but the detection routine does not detect this correctly.