Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add locale overload for formatted_size (#3084) #3087

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

gerboengels
Copy link
Contributor

Fix for issue #3084. Adds an overload to formatted_size which takes a locale, as std::formatted_size does.

The unit test is more of a "does it compile" test than actually testing locale-dependent behaviour. Is that ok? My thought was that vformat_to is already tested, so no need to repeat that here...

@vitaut vitaut merged commit 3176e0f into fmtlib:master Sep 7, 2022
@vitaut
Copy link
Contributor

vitaut commented Sep 7, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants