Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic_format_string::get() #3111

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Add basic_format_string::get() #3111

merged 1 commit into from
Sep 23, 2022

Conversation

huangqinjin
Copy link
Contributor

No description provided.

@vitaut
Copy link
Contributor

vitaut commented Sep 22, 2022

Please explain why you want to add this member function.

@huangqinjin
Copy link
Contributor Author

To conform with standard.

https://en.cppreference.com/w/cpp/utility/format/basic_format_string

@vitaut vitaut merged commit 48f525d into fmtlib:master Sep 23, 2022
@vitaut
Copy link
Contributor

vitaut commented Sep 23, 2022

Thanks!

@phprus
Copy link
Contributor

phprus commented Sep 23, 2022

@vitaut
std::basic_format_string does not contain operator basic_string_view<Char>().
Maybe remove it and replace it with get() calls?

@vitaut
Copy link
Contributor

vitaut commented Sep 23, 2022

{fmt} provides a lot of functionality not available in std::format, this is just one of them. I don't think we need to remove anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants