Fix a few bugs related to compile tests #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cache bug meant that a failed test would appear forever broken, even if the proper fix was applied.
FMT_STATIC_ASSERT is defined in posix.h so expect_compile_error was actually failing on a missing macro instead of the static assert.
The failure would happen when the main project was configured with a compiler which is not the system default. The new configuration was not forwarded to "ctest --build-and-test". This fixes it.
|
Great fixes, thanks! |
|
@dean0x7d, could you please review the updated CONTIBUTING document, particularly the part about licensing, and let me know if you agree with it being applied both to your contributions to {fmt}? The library is likely to be relicensed (#1073) so I'm collecting approval from all earlier contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some compile test bugs while working on #312 (but these bugs aren't actually specific to Intel's compiler).
expect_compileandexpect_compile_errorthe cache variable was not always unset becausemessage(FATAL_ERROR)exits immediately. Even if a test was fixed it would appear broken until the cache was reset manually.FMT_STATIC_ASSERTtest was failing for the wrong reason: missing macro instead of the actual static assert.find-package-testfailed with linker errors becausectest --build-and-testwould still use the system default.