Workaround for incompatibility between libstdc++ consteval-based std::is_constant_evaluated() implementation and clang-14 #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
reviewed
Jan 21, 2023
include/fmt/core.h
Outdated
| @@ -329,7 +329,14 @@ template <typename... T> FMT_CONSTEXPR void ignore_unused(const T&...) {} | |||
|
|
|||
| constexpr FMT_INLINE auto is_constant_evaluated( | |||
| bool default_value = false) noexcept -> bool { | |||
| #ifdef __cpp_lib_is_constant_evaluated | |||
| // Workaround for incompatible between libstdc++ consteval based | |||
There was a problem hiding this comment.
incompatible -> incompatibility
consteval based -> consteval-based
include/fmt/core.h
Outdated
| // std::is_constant_evaluated implementation and clang-14+. | ||
| // https://github.com/fmtlib/fmt/issues/3247 | ||
| #if FMT_CPLUSPLUS >= 202002L && defined(_GLIBCXX_RELEASE) && \ | ||
| _GLIBCXX_RELEASE >= 12 && FMT_CLANG_VERSION >= 14 |
There was a problem hiding this comment.
Should this be FMT_CLANG_VERSION == 14 per #3247 (comment)?
There was a problem hiding this comment.
Should be
(FMT_CLANG_VERSION >= 1400 && FMT_CLANG_VERSION < 1500)This is my mistake, I forgot about the minor version part (00):
Line 23 in f89cd27
Since bug is fixed in clang-15, I added a second condition.
…:is_constant_evaluated() implementation and clang-14 Signed-off-by: Vladislav Shchapov <[email protected]>
phprus
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #3247
cc @m5k8