Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented #335 custom printfargformatter #339

Closed
wants to merge 7 commits into from

Conversation

spacemoose
Copy link
Contributor

As discussed. Summarizing the changes:

  • printf.h created and placed PrintfArgFormat ting classes in this file.
  • Created a DefaultPrintfArgFormatter, analagous to the ArgFormatter class for the python-style formatter.
  • Added another template parameter to PrintfArgFormatter, enabling customisation of the PrintfArgFormatter through subclassing, as with the BasicArgFormatter.
  • Created a very simple unit test for the new functionality in custom-formatterer-test.cc

I hope the changes are acceptable. I open to any changes of course. If accepted, I would suggest taking PrintfArgFormatter out of internal in a next issue.

@spacemoose spacemoose closed this Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant