Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove code duplication #3448

Merged
merged 2 commits into from
May 18, 2023
Merged

remove code duplication #3448

merged 2 commits into from
May 18, 2023

Conversation

florimond-collette
Copy link
Contributor

No description provided.

@vitaut vitaut merged commit 4ce086f into fmtlib:master May 18, 2023
@vitaut
Copy link
Contributor

vitaut commented May 18, 2023

Thank you!

@jk-jeon
Copy link
Contributor

jk-jeon commented May 18, 2023

How about to revert the change for the 32-bit version and just add 8 to the result in the 64-bit version? In my opinion that's more readable and the impact is more local.

@vitaut
Copy link
Contributor

vitaut commented May 18, 2023

How about to revert the change for the 32-bit version and just add 8 to the result in the 64-bit version? In my opinion that's more readable and the impact is more local.

I was thinking about the same. A PR is welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants