Fix conversion warning in filesystem::path formatter #3806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use template character type to eliminate MSVC conversion warning when formatting a wide chararacter path: fmt\std.h(140,49): warning C4244: '=': conversion from 'const Char' to 'char', possible loss of data
vitaut
reviewed
Jan 13, 2024
include/fmt/std.h
Outdated
| @@ -120,7 +120,7 @@ template <typename Char> struct formatter<std::filesystem::path, Char> { | |||
| format_specs<Char> specs_; | |||
| detail::arg_ref<Char> width_ref_; | |||
| bool debug_ = false; | |||
| char path_type_ = 0; | |||
| Char path_type_ = 0; | |||
There was a problem hiding this comment.
Let's keep char here and use to_ascii when assigning to it in parse.
vitaut
approved these changes
Jan 13, 2024
|
Thank you! |
happymonkey1
pushed a commit
to happymonkey1/fmt
that referenced
this pull request
Apr 7, 2024
* Fix conversion warning in filesystem::path formatter Use template character type to eliminate MSVC conversion warning when formatting a wide chararacter path: fmt\std.h(140,49): warning C4244: '=': conversion from 'const Char' to 'char', possible loss of data * Review: use to_ascii instead --------- Co-authored-by: Hans-Martin B. Jensen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use template character type to eliminate MSVC conversion warning when formatting a wide chararacter path:
fmt\std.h(140,49): warning C4244: '=': conversion from 'const Char' to 'char', possible loss of data