Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel support: Add utf-8 to Windows build #3962

Merged
merged 1 commit into from
May 15, 2024
Merged

Bazel support: Add utf-8 to Windows build #3962

merged 1 commit into from
May 15, 2024

Conversation

Vertexwahn
Copy link
Contributor

@Vertexwahn Vertexwahn commented May 15, 2024

This PR only affects the Bazel build support for fmt (CMake build stays untouched). In detail:

  • Add -utf-8 to Windows Bazel build
  • Bump Bazel version to document which Bazel version was used to test this
  • Remove from documentation WORKSPACE system section, since Bzlmod should be used from now on (we still need to keep WORKSPACE.bazel` marker file - will be deprecated at some time and then be removed)

@vitaut vitaut merged commit a4715c4 into fmtlib:master May 15, 2024
40 checks passed
@vitaut
Copy link
Contributor

vitaut commented May 15, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants