Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken CI for shared library on macos and linux #4151

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

phprus
Copy link
Contributor

@phprus phprus commented Sep 3, 2024

Bug is introduced in #2293 (shared library build not working in CI)

Additionally, a C++23 for shared libraries is added.

I think it would be better to fix #4150 before this and use gcc-14 instead of gcc-11 in this PR or make this change later.

@phprus
Copy link
Contributor Author

phprus commented Sep 4, 2024

@vitaut review this PR please.

@vitaut vitaut merged commit 1e0771c into fmtlib:master Sep 4, 2024
44 checks passed
@vitaut
Copy link
Contributor

vitaut commented Sep 4, 2024

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gcc-13/14 c++23 build errors
2 participants