Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for some issues with modules builds #4152

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

kamrann
Copy link
Contributor

@kamrann kamrann commented Sep 4, 2024

  1. I think some recent changes caused a regression by rearranging some code such that some out-of-line member function definitions ended up in the module export scope. The errors encountered (on Clang) were as follows:
In file included from C:\Coding\Build2\third-party-packaging\build2-packaging\fmt\fmt\fmt\src\fmt.cc:107:
In file included from C:\Coding\Build2\third-party-packaging\build2-packaging\fmt\fmt\fmt/include\fmt/args.h:17:
In file included from C:\Coding\Build2\third-party-packaging\build2-packaging\fmt\fmt\fmt/include\fmt\format.h:41:
C:\Coding\Build2\third-party-packaging\build2-packaging\fmt\fmt\fmt/include\fmt\base.h:2471:41: error: cannot export 'do_check_arg_id' as it is not at namespace scope
 2471 | FMT_CONSTEXPR void parse_context<Char>::do_check_arg_id(int arg_id) {
      |                    ~~~~~~~~~~~~~~~~~~~~~^
  1. Unsure if this was a recent regression or not, but the MSVC-specific inclusion of intrin.h was being done within the module purview.

@vitaut vitaut merged commit b4aea98 into fmtlib:master Sep 4, 2024
43 checks passed
@vitaut
Copy link
Contributor

vitaut commented Sep 4, 2024

Thank you!

@kamrann kamrann deleted the pr/modules-fixes branch September 20, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants