Implement fmt::join for tuple-like objects #4230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
reviewed
Nov 7, 2024
include/fmt/ranges.h
Outdated
| @@ -696,18 +696,18 @@ auto join(It begin, Sentinel end, string_view sep) -> join_view<It, Sentinel> { | |||
| * fmt::print("{:02}", fmt::join(v, ", ")); | |||
| * // Output: 01, 02, 03 | |||
| */ | |||
| template <typename Range> | |||
| template <typename Range, FMT_ENABLE_IF(!fmt::is_tuple_like<Range>::value)> | |||
There was a problem hiding this comment.
Why qualify this with fmt::? I don't think ADL applies here.
There was a problem hiding this comment.
You are right.
Removed fmt::.
vitaut
reviewed
Nov 8, 2024
vitaut
reviewed
Nov 9, 2024
test/ranges-test.cc
Outdated
Comment on lines
426
to
428
| // Tuple-like. | ||
| auto t5 = tuple_like{42, "foo"}; | ||
| EXPECT_EQ(fmt::format("{}", t5), "(42, \"foo\")"); |
There was a problem hiding this comment.
This test case looks identical to one of the above:
auto t = tuple_like{42, "foo"};
EXPECT_EQ(fmt::format("{}", t), "(42, \"foo\")");
Did you mean to use join here?
There was a problem hiding this comment.
Yes, I lost fmt::join.
Signed-off-by: Vladislav Shchapov <[email protected]>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #4226