Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4190
Have tested on my local machine and couldn't compile
Without this, now can
Don't think can write a test for this change as currently the tests use:
fmt/test/CMakeLists.txt
Lines 101 to 112 in 9ced61b
Which is presumably how it doesn't get picked up an not-exported right now. A test for its usage does already exist anyway:
fmt/test/module-test.cc
Lines 385 to 394 in 9ced61b