Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ArgMap::init not explicitly instantiated #563

Merged
merged 2 commits into from
Sep 4, 2017
Merged

Make ArgMap::init not explicitly instantiated #563

merged 2 commits into from
Sep 4, 2017

Conversation

Yelnats321
Copy link
Contributor

PR for issue #560.

vitaut
vitaut requested changes Sep 3, 2017
View reviewed changes
Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you keep the init method outside of the class (in the header)?

@Yelnats321
Copy link
Contributor Author

The diff is kind of hard to read but I just moved it out and also removed FMT_API since it's a template function that's defined in the header too.

@vitaut vitaut merged commit 1658953 into fmtlib:master Sep 4, 2017
@vitaut
Copy link
Contributor

vitaut commented Sep 4, 2017

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaut vitaut vitaut requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yelnats321 @vitaut