Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fn: upgrade to gRPC 1.17 #1389

Merged
merged 1 commit into from
Jan 25, 2019
Merged

fn: upgrade to gRPC 1.17 #1389

merged 1 commit into from
Jan 25, 2019

Conversation

skinowski
Copy link
Member

We'd like to ingest: grpc/grpc-go#2307

kmjohansen
kmjohansen approved these changes Jan 24, 2019
View reviewed changes
Copy link

@kmjohansen kmjohansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; this looks alright to me, but it's obviously it will help to have successful tests against the changes.

@rdallman
Copy link
Contributor

the system tests don't test the new behavior, but at least some rpc's are going to get executed (there's some concurrency stuff too so they're not just lollipop tests)

@skinowski skinowski merged commit a540ab0 into fnproject:master Jan 25, 2019
@skinowski skinowski deleted the upgrade_grpc_1.17 branch January 25, 2019 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdallman rdallman rdallman approved these changes

@kmjohansen kmjohansen kmjohansen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skinowski @rdallman @kmjohansen