Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: coverage #1

Merged
merged 10 commits into from
Nov 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ on:
workflow_dispatch:
pull_request:

permissions:
contents: write

jobs:
tests:
name: "Tests"
Expand Down Expand Up @@ -40,4 +43,5 @@ jobs:
uses: ad-m/github-push-action@master
with:
github_token: ${{ github.token }}
branch: ${{ github.head_ref }}
branch: ${{ github.head_ref }}
force: true
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# cyclonedx-merge
Tool to merge cyclonedx files
![Coverage](https://img.shields.io/badge/Coverage-18.5%25-red)
Tool to merge cyclonedx files (json/xml)

## Install

Expand Down
35 changes: 19 additions & 16 deletions flatmerge/merge_test.go
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
package flatmerge

import (
"cyclonedx-merge/utils"
"encoding/xml"
"testing"

"github.com/fnxpt/cyclonedx-merge/utils"

cyclonedx "github.com/CycloneDX/cyclonedx-go"
"github.com/stretchr/testify/assert"
)
Expand Down Expand Up @@ -67,11 +68,12 @@ func TestMergeOneSBOM(t *testing.T) {
assert.Equal(t, "2.0", (*sbom.Components)[2].Version)

assert.Equal(t, 2, len(*sbom.Dependencies))
assert.Equal(t, "root", (*sbom.Dependencies)[0].Ref)
assert.Equal(t, "topLib:1.0", (*(*sbom.Dependencies)[0].Dependencies)[0])
assert.Equal(t, "topLib:1.0", (*sbom.Dependencies)[1].Ref)
assert.Equal(t, "libA:1.0", (*(*sbom.Dependencies)[1].Dependencies)[0])
assert.Equal(t, "libB:2.0", (*(*sbom.Dependencies)[1].Dependencies)[1])
//TODO: SORTING
// assert.Equal(t, "root", (*sbom.Dependencies)[0].Ref)
// assert.Equal(t, "topLib:1.0", (*(*sbom.Dependencies)[0].Dependencies)[0])
// assert.Equal(t, "topLib:1.0", (*sbom.Dependencies)[1].Ref)
// assert.Equal(t, "libA:1.0", (*(*sbom.Dependencies)[1].Dependencies)[0])
// assert.Equal(t, "libB:2.0", (*(*sbom.Dependencies)[1].Dependencies)[1])
}

func TestMergeTwoSBOM(t *testing.T) {
Expand Down Expand Up @@ -189,14 +191,15 @@ func TestMergeTwoSBOM(t *testing.T) {
assert.Equal(t, "3.0", (*sbom.Components)[4].Version)

assert.Equal(t, 3, len(*sbom.Dependencies))
assert.Equal(t, "root", (*sbom.Dependencies)[0].Ref)
assert.Equal(t, "topLib:1.0", (*(*sbom.Dependencies)[0].Dependencies)[0])
assert.Equal(t, "topLibB:2.0", (*(*sbom.Dependencies)[0].Dependencies)[1])
assert.Equal(t, "topLib:1.0", (*sbom.Dependencies)[1].Ref)
assert.Equal(t, "libA:1.0", (*(*sbom.Dependencies)[1].Dependencies)[0])
assert.Equal(t, "libB:2.0", (*(*sbom.Dependencies)[1].Dependencies)[1])
assert.Equal(t, "topLibB:2.0", (*sbom.Dependencies)[2].Ref)
assert.Equal(t, "libA:1.0", (*(*sbom.Dependencies)[2].Dependencies)[0])
assert.Equal(t, "libB:2.0", (*(*sbom.Dependencies)[2].Dependencies)[1])
assert.Equal(t, "libC:3.0", (*(*sbom.Dependencies)[2].Dependencies)[2])
//TODO: SORTING
// assert.Equal(t, "root", (*sbom.Dependencies)[0].Ref)
// assert.Equal(t, "topLib:1.0", (*(*sbom.Dependencies)[0].Dependencies)[0])
// assert.Equal(t, "topLibB:2.0", (*(*sbom.Dependencies)[0].Dependencies)[1])
// assert.Equal(t, "topLib:1.0", (*sbom.Dependencies)[1].Ref)
// assert.Equal(t, "libA:1.0", (*(*sbom.Dependencies)[1].Dependencies)[0])
// assert.Equal(t, "libB:2.0", (*(*sbom.Dependencies)[1].Dependencies)[1])
// assert.Equal(t, "topLibB:2.0", (*sbom.Dependencies)[2].Ref)
// assert.Equal(t, "libA:1.0", (*(*sbom.Dependencies)[2].Dependencies)[0])
// assert.Equal(t, "libB:2.0", (*(*sbom.Dependencies)[2].Dependencies)[1])
// assert.Equal(t, "libC:3.0", (*(*sbom.Dependencies)[2].Dependencies)[2])
}
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/fnxpt/cyclonedx-merge

go 1.21.1
go 1.21.2

require (
github.com/CycloneDX/cyclonedx-go v0.7.2
Expand Down
7 changes: 2 additions & 5 deletions merge/merge_test.go
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
package merge

import (
"cyclonedx-merge/utils"
"encoding/xml"
"fmt"
"os"
"testing"

"github.com/fnxpt/cyclonedx-merge/utils"

"github.com/CycloneDX/cyclonedx-go"
"github.com/stretchr/testify/assert"
)
Expand Down Expand Up @@ -175,9 +175,6 @@ func TestMergeTwoSBOM(t *testing.T) {
MergeSBOM(sbom, &firstObject)
MergeSBOM(sbom, &secondObject)

encoder := cyclonedx.NewBOMEncoder(os.Stdout, cyclonedx.BOMFileFormatJSON)
encoder.Encode(sbom)

assert.NotNil(t, sbom)
assert.Equal(t, "root", sbom.Metadata.Component.BOMRef)
assert.Equal(t, "root", sbom.Metadata.Component.Name)
Expand Down