Feature/bump focus trap 4.x #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colmbrady
force-pushed
the
feature/bump_focus_trap_4.x
branch
from
5fddcc7
to
c8cf9bc
Compare
|
Hi, I just noticed your package-lock.json is showing
So this can’t be merged in. You need to change your |
colmbrady
force-pushed
the
feature/bump_focus_trap_4.x
branch
from
c8cf9bc
to
a424915
Compare
colmbrady
force-pushed
the
feature/bump_focus_trap_4.x
branch
from
a424915
to
6e82e4a
Compare
|
Taken care of in 4b6e412 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P.R bumps focus-trap to 4.x version.
This resolves a number of issues for us regarding nested focus traps. I believe the commit will also resolve #27.
Ive verified Unit tests pass and for my usage - there were no other upgrade steps we needed to do.