Fix blank content-encoding headers #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The S3 docs claim that you should set the content-encoding to aws-chunked for a streaming upload. This however results in S3 serving files with a blank content-encoding header. After discussion with AWS support, it appears that setting the content-encoding to aws-chunked isn't actually necessary since S3 can infer this from other headers present in the request
|
good hunting @fcheung |
lanej
added a commit
that referenced
this pull request
Jul 8, 2015
Fix blank content-encoding headers
|
Yeesh, thanks @fcheung for continuing to chase this one. |
endgame
added a commit
to endgame/amazonka
that referenced
this pull request
Oct 13, 2021
https://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-streaming.html says that chunked requests should set `Content-Encoding: aws-chunked`. S3 strips any occurrence of `aws-chunked` from that header, and stores the remainder as the `ContentEncoding` metadata on the object. It isn't very smart about this: if `aws-chunked` is the only encoding listed, S3 will store the empty string as the encoding, which breaks some HTTP clients and CDNs. Multiple AWS SDKs appear to have hit this issue, and the developers of `fog` contacted AWS support. Their suggestion was to omit the `Content-Encoding:` header entirely because S3 is capable of figuring it out: fog/fog-aws#147
endgame
added a commit
to endgame/amazonka
that referenced
this pull request
Oct 13, 2021
https://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-streaming.html says that chunked requests should set `Content-Encoding: aws-chunked`. S3 strips any occurrence of `aws-chunked` from that header, and stores the remainder as the `ContentEncoding` metadata on the object. It isn't very smart about this: if `aws-chunked` is the only encoding listed, S3 will store the empty string as the encoding, which breaks some HTTP clients and CDNs. Multiple AWS SDKs appear to have hit this issue, and the developers of `fog` contacted AWS support. Their suggestion was to omit the `Content-Encoding:` header entirely because S3 is capable of figuring it out: fog/fog-aws#147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The S3 docs claim that you should set the content-encoding to aws-chunked
for a streaming upload. This however results in S3 serving files with a blank
content-encoding header. After discussion with AWS support, it appears
that setting the content-encoding to aws-chunked isn't actually necessary
since S3 can infer this from other headers present in the request
See #130, #106 , #75