Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix S3 #delete_multiple_objects for UTF-8 names #310

Merged
merged 1 commit into from
Oct 17, 2016
Merged

Conversation

alepore
Copy link
Contributor

@alepore alepore commented Oct 15, 2016

Hello!
I was debugging backup/backup#670 and i found out that fog-aws' #delete_multiple_objects does not work with UTF-8 file names.

The problem is in the 'Content-Length' header, String#length is not the right method to find UTF-8 strings size:

> "fØg_öbjèct".length
 => 10
> "fØg_öbjèct".bytesize
 => 13

Please review the test, it not very clear to me if that's enough (#311)

@lanej
Copy link
Member

lanej commented Oct 17, 2016

@alepore good catch.

@lanej lanej merged commit ad1a111 into fog:master Oct 17, 2016
@geemus
Copy link
Member

geemus commented Oct 18, 2016

Thanks!

@alepore alepore deleted the s3-utf8 branch November 18, 2016 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants