fix S3 #delete_multiple_objects for UTF-8 names #310
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I was debugging backup/backup#670 and i found out that fog-aws'
#delete_multiple_objects
does not work with UTF-8 file names.The problem is in the 'Content-Length' header,
String#length
is not the right method to find UTF-8 strings size:Please review the test, it not very clear to me if that's enough (#311)