Mock method for AWS S3 post_object_hidden_fields #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think in other (similar) cases we have created a little module that has the method in this file. Then you can just "include" that module in to both real/mock and you don't have to copy paste. Does that make sense/work for you? |
|
Yep, I've just made in this manner. My only doubt is about the doc comment... it goes before the method declaration or inside the |
|
Hmm. I guess with the definition probably... |
|
Yeah, how you did it seems fine. Thanks! |
geemus
added a commit
that referenced
this pull request
Mar 4, 2015
…ields Mock method for AWS S3 post_object_hidden_fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
post_object_hidden_fieldsdoesn't make any external call, can be used as Mock method. Tell me if there a more elegant way to do this instead of copy & paste.