Update build to babel 7 and configure to compile to modern targets #196
Conversation
| [ | ||
| "@babel/preset-env", | ||
| { | ||
| "targets": { |
There was a problem hiding this comment.
Maybe we could do both a modern and a legacy build? I think a good number of people still need to support IE 11.
There was a problem hiding this comment.
Done. Added es5 (ie11) compatible build
blikblum
force-pushed
the
update-babel
branch
from
2d46643
to
27ead43
Compare
|
Rebased on top of master to fix conflict |
|
👍 |
| } | ||
| } | ||
|
|
||
| const modernBrowsers = [ |
There was a problem hiding this comment.
probably worth using https://github.com/browserslist/browserslist instead?
There was a problem hiding this comment.
This can be done is a followup PR.
There was a problem hiding this comment.
given how much further into the future things are now, it's probably worth updating this to https://github.com/browserslist/browserslist rather than in followup at this point. Just in case it takes another year before it actually lands =(
|
@devongovett good to merge? |
|
Please can this be merged @devongovett |
|
Any update on this? |
|
bruh |
|
could this be merged? |
|
Would be great to get this merged in... |
|
is there any update to this? It's been 2 years! You mention on the pdfkit github this ticket, we want to know if it's likely to be merged, or if we need to move to a different supported library |
|
Could this be merged? |
This updates the build system to use babel 7 and configure it to target modern systems.
Together with foliojs/dfa#1 allows to remove a bunch of big and slow code