Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modal] Added inverted variant #34

Closed
wants to merge 2 commits into from
Closed

[Modal] Added inverted variant #34

wants to merge 2 commits into from

Conversation

lubber-de
Copy link
Member

Examples according to fomantic/Fomantic-UI#157

@y0hami y0hami added the New Content New content for new additions to the core library label Oct 15, 2018
@@ -509,6 +526,25 @@ themes : ['Default', 'Material']
</div>
</div>

<div class="no example">
<h4 class="ui header">Inverted Variant</h4>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title should be only "Inverted" to be consistent to the other modules

;
</div>
<p>... or default black dimmer</p>
<div class="code" data-demo="true" data-eval="$('.mini.test.inverted.modal').not('.basic').modal('show')">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After opening the the "white dimmer" variation, running this always shows the white dimmer.
peek 2018-10-16 07-56

Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de
Copy link
Member Author

Merged separately by @hammy2899 into #38

@lubber-de lubber-de closed this Oct 23, 2018
@lubber-de lubber-de deleted the inverted_modal branch October 23, 2018 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Content New content for new additions to the core library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants