Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popup] Misaligned positioning when parent has scrollbar #1918

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

lubber-de
Copy link
Member

Description

Popups which are right positioned are misaligned by the width of a possible scrollbar (or any margin of the parent element (usually body))

Testcase

The body has a scrollbar.
Open the modal by clicking the button and hover over the icon to see the popup.

Broken

The popup arrow is misaligned to the right by the width of the body scrollbar
https://jsfiddle.net/dutrieux/npjsc5d8/

Fixed

Arrow positioned correctly again
https://jsfiddle.net/lubber/zh5xypob/

Screenshot

Broken

image

Fixed

image

Closes

#1899

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/javascript Anything involving JavaScript state/awaiting-reviews Pull requests which are waiting for reviews labels Mar 19, 2021
@lubber-de lubber-de added this to the 2.8.x milestone Mar 19, 2021
exoego
exoego previously approved these changes Mar 19, 2021
Copy link
Contributor

@exoego exoego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dutrieux
Copy link
Contributor

The behavior is not the same with pre-formatted popup : https://jsfiddle.net/dutrieux/npgdc2mw/

popup

@lubber-de lubber-de added the state/on-hold Issues and pull requests which are on hold for any reason label Mar 19, 2021
@lubber-de lubber-de marked this pull request as draft March 19, 2021 15:16
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Mar 19, 2021
@lubber-de lubber-de modified the milestones: 2.8.x, 2.9.x Sep 6, 2021
# Conflicts:
#	src/definitions/modules/popup.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/javascript Anything involving JavaScript state/on-hold Issues and pull requests which are on hold for any reason type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants