Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Progress] Display dark text on light inverted backgrounds #196

Merged
merged 2 commits into from
Oct 24, 2018
Merged

[Progress] Display dark text on light inverted backgrounds #196

merged 2 commits into from
Oct 24, 2018

Conversation

lubber-de
Copy link
Member

Description

Some progress text is unreadable on inverted progress bars, because their background color is too light.
This PR changes the text colors from white to black on inverted yellow|olive|teal|grey progress

Screenshot

Before

image

After

image

@lubber-de lubber-de added lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews labels Oct 23, 2018
@lubber-de lubber-de changed the title fix(progress): display dark Text on light inverted backgrounds [Progress] Display dark text on light inverted backgrounds Oct 23, 2018
@ColinFrick
Copy link
Member

We could also just change the @invertedProgressColor to something like @black:
image

This maybe would look more consistent.

@lubber-de
Copy link
Member Author

lubber-de commented Oct 24, 2018 •
edited
Loading

Matter of taste 😄
Well, I currently implemented it the same way as I did for inverted toast and using black on any background color looked also not right to me somehow.
But I am totally open to this. If we decide to use your proposal then I suggest to change this for every inverted toast aswell then to follow same principles. Let's see what the others think

@y0hami
Copy link
Member

y0hami commented Oct 24, 2018

I agree with @ColinFrick so that it is consistent.

@y0hami y0hami added the type/feat Any feature requests or improvements label Oct 24, 2018
@lubber-de
Copy link
Member Author

OK, convinced 😉. I am gonna changing this Pr accordingly and for toast I am creating a separate PR

@prudho
Copy link
Contributor

prudho commented Oct 24, 2018

Was also on @ColinFrick's opinion.

ColinFrick
ColinFrick approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de mentioned this pull request Oct 24, 2018
Merged
y0hami
y0hami approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 78dece2 into fomantic:beta Oct 24, 2018
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Oct 24, 2018
@lubber-de lubber-de deleted the fix/inverted_progress_textcolor branch October 24, 2018 08:21
@y0hami y0hami mentioned this pull request Nov 14, 2018
Merged
@lubber-de lubber-de added this to the 2.7.0 milestone Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinFrick ColinFrick ColinFrick approved these changes

@y0hami y0hami y0hami approved these changes

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/css Anything involving CSS type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lubber-de @ColinFrick @y0hami @prudho