Remove trailing CSS unit values & duplication fixes #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y0hami
added
lang/css
ColinFrick
previously approved these changes
Dec 10, 2018
lubber-de
previously approved these changes
Dec 10, 2018
added 6 commits
December 10, 2018 19:14
y0hami
dismissed stale reviews from lubber-de, ColinFrick, and prudho
via
e22e8e6
|
I have looked over all the values changed manually and they all look fine to me. |
lubber-de
requested changes
Dec 10, 2018
lubber-de
requested changes
Dec 10, 2018
y0hami
changed the title
|
@fomantic/collaborators ready for review 😃 |
lubber-de
requested changes
Dec 11, 2018
|
@lubber-de now? 😛 |
This was referenced Dec 21, 2018
Merged
y0hami
removed
state/awaiting-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed all trailing
pxvalues from definitions and default theme to help with CSS linters.0px=>0