Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not flash loading class in modal refresh #2982

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Jan 19, 2024

introduced in Semantic-Org/Semantic-UI#5578

Is the hack using loading class still needed? It causes a problem in out environment because it flashes the class causing our observers to trigger.

Maybe more changes/LoC removed are needed/wanted.

@prudho
Copy link
Contributor

prudho commented Jan 30, 2024

Remove the loading hack looks ok to me, but deleting the CSS is not a good idea IMHO. Some users might want to make their modals in a loading state, when using ajax for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants