Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cryptic error on some sysimage builds on Julia 1.8.5 #2600

Merged
merged 1 commit into from
Jul 12, 2023
Merged

fix: cryptic error on some sysimage builds on Julia 1.8.5 #2600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/webserver/Dynamic.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ function send_notebook_changes!(🙋::ClientRequest; commentary::Any=nothing, sk
if client.connected_notebook !== nothing && client.connected_notebook.notebook_id == 🙋.notebook.notebook_id
current_dict = get(current_state_for_clients, client, :empty)
patches = Firebasey.diff(current_dict, notebook_dict)
patches_as_dicts::Array{Dict} = Firebasey._convert(Array{Dict}, patches)
patches_as_dicts = Firebasey._convert(Vector{Dict}, patches)
current_state_for_clients[client] = deep_enough_copy(notebook_dict)

# Make sure we do send a confirmation to the client who made the request, even without changes
Expand Down
Loading