Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove check for description character limit [com.google.fonts/check/description/max_length] #3829

Closed
RosaWagner opened this issue Jul 20, 2022 · 0 comments
Closed

Remove check for description character limit [com.google.fonts/check/description/max_length] #3829

RosaWagner opened this issue Jul 20, 2022 · 0 comments
Assignees
@felipesanches
Labels
P1 Quick
Milestone
0.8.10

Comments

@RosaWagner
Copy link
Contributor

Found in google/fonts#4964

🔥 FAIL: DESCRIPTION.en_us.html must have less than 2000 bytes. ([com.google.fonts/check/description/max_length](https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/googlefonts.html#com.google.fonts/check/description/max_length))
🔥 FAIL DESCRIPTION.en_us.html must have size smaller than 2000 bytes. [code: too-long]

Recent requirements from GF marketing team is to remove character limit on description. GF specimen page has been updated to allow bigger description text from designers.
@RosaWagner RosaWagner added this to the 0.8.10 milestone Jul 20, 2022
@RosaWagner RosaWagner changed the title Remove description character limit [com.google.fonts/check/description/max_length] Remove check for description character limit [com.google.fonts/check/description/max_length] Jul 20, 2022
@felipesanches felipesanches self-assigned this Jul 20, 2022
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Jul 20, 2022
@felipesanches
Deprecate DESCRIPTION.en_us.html max-length check
ddec947 
Removed from the Google Fonts Profile:
com.google.fonts/check/description_max_length

Recent requirement from GF marketing team is to remove character limit on description.
GF specimen page has been updated to allow bigger description text from designers.
(issue fonttools#3829)
@felipesanches felipesanches mentioned this issue Jul 20, 2022
Merged
felipesanches added a commit that referenced this issue Jul 20, 2022
@felipesanches
Deprecate DESCRIPTION.en_us.html max-length check
5534c9f 
Removed from the Google Fonts Profile:
com.google.fonts/check/description_max_length

Recent requirement from GF marketing team is to remove character limit on description.
GF specimen page has been updated to allow bigger description text from designers.
(issue #3829)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipesanches felipesanches

Labels
P1 Quick
Projects
None yet
Milestone
0.8.10
Development

No branches or pull requests
2 participants
@felipesanches @RosaWagner