Declare explicit target environments for tox #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SnoopJ
changed the title
anthrotype
reviewed
Oct 28, 2022
README.md
Outdated
| Without any options, `tox` will run the tests against the current python version where | ||
| `tox` itself was installed: | ||
| Without any options, `tox` will run the tests against all of the library's | ||
| target Python versions, which will cause an error if one of those versions is |
There was a problem hiding this comment.
you mean it does not cause an error...
There was a problem hiding this comment.
oops, yes, I forgot to change that
my understanding is that the option prevent tox from exiting with a non-zero error status when any of the interpreters is missing |
|
anyway this is only ever relevant when running tox locally, because on the CI we call pytest directly as far as I can tell |
|
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned on #58, this is a PR to update
tox.inito include an explicit list of target environments forunicodedata2Note that there is aI'm wrong aboutskip_missing_interpretersoption (--skip-missing-interpreterson the command-line) that "skips" any missing versions, but unfortunately setting this option causes a success message to be emitted for those versions, so I've left it out of this changeset.skip_missing_interpreters, not sure why I saw the behavior that I did, but having difficulty reproducing it now. Adding to this PR.