Sm/event-task-custom-fields #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shetzel
requested changes
Jul 17, 2023
| types: Array<{ name: string; members: string[] }>; | ||
| version: string; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
This type isn't defined/exported in SDR already?
There was a problem hiding this comment.
defined, yes. Exported, not at the top-level.
I'm going to get it from jsforce
WillieRuemmele
approved these changes
Jul 25, 2023
WillieRuemmele
approved these changes
Jul 28, 2023
| ignoreDeclaration: true, | ||
| numberParseOptions: { leadingZeros: false, hex: false }, | ||
| // make sure types and members is always an array | ||
| isArray: (name: string) => ['types', 'members'].includes(name), |
amtrack
reviewed
Jul 30, 2023
amtrack
suggested changes
Jul 30, 2023
Co-authored-by: Matthias Rolke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event/Task in profiles now match Activity in (package.xml).
rewrite of the Profile Rewrite process
forcedotcom/cli#2278
@W-13753544@