build(salesforcedx-vscode): update node to v16 and npm v8

[mohanraj-r]

What does this PR do?

• Update node to Active LTS v16 (EOL 2024-04-30)
• Update to npm v8 which is bundled with Node v16
• Retrace/redo build(salesforcedx-vscode): update node to v16 and switch from npm to yarn #4042 to make sure nothing was missed and check if there is a simpler way to continue to use npm and not switch to yarn

What issues does this PR fix or reference?

@W-11004197@

Functionality Before

• Node v14 was used with older lockfile format

Functionality After

• Node v16 used with npm v8 and lockfile format v3

Notes

• Run npm run reinstall after merge (remind team in slack)

[mohanraj-r]

6bbf3d0: With lockfile-version set to 2 or 3, build vscode:package errors with npm ERR! code ELSPROBLEMS - unit, integ tests pass though.

lerna ERR! npm run vscode:package stderr:
npm WARN config production Use `--omit=dev` instead.
 ERROR  Command failed: npm list --production --parseable --depth=99999 --loglevel=error
npm ERR! code ELSPROBLEMS
npm ERR! missing: @salesforce/[email protected], required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: @types/[email protected], required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: @types/[email protected], required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: @types/mocha@^5, required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: @types/[email protected], required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: @types/rimraf@^2.0.2, required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: @types/sinon@^2.3.7, required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: chai@^4.0.2, required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: [email protected], required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: mocha-junit-reporter@^1.23.3, required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: mocha-multi-reporters@^1.1.7, required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: mocha@^5, required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: [email protected], required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: nyc@^13, required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: [email protected], required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: sinon@^13.0.1, required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: [email protected], required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: [email protected], required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: @salesforce/[email protected], required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: @types/[email protected], required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: @types/[email protected], required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: @types/[email protected], required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: @types/mocha@^5, required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: @types/[email protected], required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: @types/[email protected], required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: @types/sinon@^2.3.7, required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: @types/[email protected], required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: chai@^4.0.2, required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: mocha-junit-reporter@^1.23.3, required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: mocha-multi-reporters@^1.1.7, required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: mocha@^5, required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: [email protected], required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: nyc@^13, required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: [email protected], required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: [email protected], required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: sinon@^13.0.1, required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: [email protected], required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]

c36791f: With lockfile-version=1 vsce package fails with different error (unit, integ tests pass). Same result with or without npm workspaces.

npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@salesforce%2fsalesforcedx-visualforce-markup-language-server - Not found
npm ERR! 404 
npm ERR! 404  '@salesforce/[email protected]' is not in this registry.
npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/circleci/.npm/_logs/2022-04-28T04_58_34_575Z-debug-0.log
npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
lerna ERR! npm prune --production exited 1 in '@salesforce/salesforcedx-visualforce-language-server'
lerna ERR! npm prune --production exited 1 in '@salesforce/salesforcedx-visualforce-language-server'
lerna WARN complete Waiting for 2 child processes to exit. CTRL-C to exit immediately.
npm WARN cleanup Failed to remove some directories [
npm WARN cleanup   [
npm WARN cleanup     undefined,
npm WARN cleanup     AssertionError [ERR_ASSERTION]: rimraf: missing path
npm WARN cleanup         at rimraf (/home/circleci/project/node_modules/npm/node_modules/rimraf/rimraf.js:54:3)
npm WARN cleanup         at node:internal/util:360:7
npm WARN cleanup         at new Promise (<anonymous>)
npm WARN cleanup         at rimraf (node:internal/util:346:12)
npm WARN cleanup         at /home/circleci/project/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:532:20
npm WARN cleanup         at Array.map (<anonymous>)
npm WARN cleanup         at Arborist.[rollbackCreateSparseTree] (/home/circleci/project/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:532:8)
npm WARN cleanup         at Arborist.[reifyPackages] (/home/circleci/project/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:235:31)
npm WARN cleanup         at async Arborist.reify (/home/circleci/project/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:155:5)
npm WARN cleanup         at async Prune.exec (/home/circleci/project/node_modules/npm/lib/commands/prune.js:28:5)
npm WARN cleanup         at async module.exports (/home/circleci/project/node_modules/npm/lib/cli.js:78:5) {
npm WARN cleanup       generatedMessage: false,
npm WARN cleanup       code: 'ERR_ASSERTION',
npm WARN cleanup       actual: undefined,
npm WARN cleanup       expected: true,
npm WARN cleanup       operator: '=='
npm WARN cleanup     }
npm WARN cleanup   ]
npm WARN cleanup ]
npm ERR! process terminated
npm ERR! signal SIGHUP

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/circleci/.npm/_logs/2022-04-28T04_58_32_891Z-debug-0.log
npm WARN cleanup Failed to remove some directories [
npm WARN cleanup   [
npm WARN cleanup     undefined,
npm WARN cleanup     AssertionError [ERR_ASSERTION]: rimraf: missing path
npm WARN cleanup         at rimraf (/home/circleci/project/node_modules/npm/node_modules/rimraf/rimraf.js:54:3)
npm WARN cleanup         at node:internal/util:360:7
npm WARN cleanup         at new Promise (<anonymous>)
npm WARN cleanup         at rimraf (node:internal/util:346:12)
npm WARN cleanup         at /home/circleci/project/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:532:20
npm WARN cleanup         at Array.map (<anonymous>)
npm WARN cleanup         at Arborist.[rollbackCreateSparseTree] (/home/circleci/project/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:532:8)
npm WARN cleanup         at Arborist.[reifyPackages] (/home/circleci/project/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:235:31)
npm WARN cleanup         at async Arborist.reify (/home/circleci/project/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:155:5)
npm WARN cleanup         at async Prune.exec (/home/circleci/project/node_modules/npm/lib/commands/prune.js:28:5)
npm WARN cleanup         at async module.exports (/home/circleci/project/node_modules/npm/lib/cli.js:78:5) {
npm WARN cleanup       generatedMessage: false,
npm WARN cleanup       code: 'ERR_ASSERTION',
npm WARN cleanup       actual: undefined,
npm WARN cleanup       expected: true,
npm WARN cleanup       operator: '=='
npm WARN cleanup     }
npm WARN cleanup   ]
npm WARN cleanup ]
npm ERR! process terminated
npm ERR! signal SIGHUP

[mohanraj-r]

Retracing/redoing steps with npm didn't help. Exploring alt solutions in #4042