build(salesforcedx-vscode): update node to v16 and npm v8 #4067

mohanraj-r · 2022-04-28T02:35:00Z

What does this PR do?

Update node to Active LTS v16 (EOL 2024-04-30)
Update to npm v8 which is bundled with Node v16
Retrace/redo build(salesforcedx-vscode): update node to v16 and switch from npm to yarn #4042 to make sure nothing was missed and check if there is a simpler way to continue to use npm and not switch to yarn

What issues does this PR fix or reference?

@W-11004197@

Functionality Before

Node v14 was used with older lockfile format

Functionality After

Node v16 used with npm v8 and lockfile format v3

Notes

Run npm run reinstall after merge (remind team in slack)

to workaround build failures due to peer deps

This reverts commit 6bbf3d0.

mohanraj-r · 2022-04-28T04:31:43Z

6bbf3d0: With lockfile-version set to 2 or 3, build vscode:package errors with npm ERR! code ELSPROBLEMS - unit, integ tests pass though.

lerna ERR! npm run vscode:package stderr:
npm WARN config production Use `--omit=dev` instead.
 ERROR  Command failed: npm list --production --parseable --depth=99999 --loglevel=error
npm ERR! code ELSPROBLEMS
npm ERR! missing: @salesforce/[email protected], required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: @types/[email protected], required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: @types/[email protected], required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: @types/mocha@^5, required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: @types/[email protected], required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: @types/rimraf@^2.0.2, required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: @types/sinon@^2.3.7, required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: chai@^4.0.2, required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: [email protected], required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: mocha-junit-reporter@^1.23.3, required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: mocha-multi-reporters@^1.1.7, required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: mocha@^5, required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: [email protected], required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: nyc@^13, required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: [email protected], required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: sinon@^13.0.1, required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: [email protected], required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: [email protected], required by salesforcedx-apex-debugger@npm:@salesforce/[email protected]
npm ERR! missing: @salesforce/[email protected], required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: @types/[email protected], required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: @types/[email protected], required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: @types/[email protected], required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: @types/mocha@^5, required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: @types/[email protected], required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: @types/[email protected], required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: @types/sinon@^2.3.7, required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: @types/[email protected], required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: chai@^4.0.2, required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: mocha-junit-reporter@^1.23.3, required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: mocha-multi-reporters@^1.1.7, required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: mocha@^5, required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: [email protected], required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: nyc@^13, required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: [email protected], required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: [email protected], required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: sinon@^13.0.1, required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]
npm ERR! missing: [email protected], required by salesforcedx-utils-vscode@npm:@salesforce/[email protected]

c36791f: With lockfile-version=1 vsce package fails with different error (unit, integ tests pass). Same result with or without npm workspaces.

npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@salesforce%2fsalesforcedx-visualforce-markup-language-server - Not found
npm ERR! 404 
npm ERR! 404  '@salesforce/[email protected]' is not in this registry.
npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/circleci/.npm/_logs/2022-04-28T04_58_34_575Z-debug-0.log
npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
lerna ERR! npm prune --production exited 1 in '@salesforce/salesforcedx-visualforce-language-server'
lerna ERR! npm prune --production exited 1 in '@salesforce/salesforcedx-visualforce-language-server'
lerna WARN complete Waiting for 2 child processes to exit. CTRL-C to exit immediately.
npm WARN cleanup Failed to remove some directories [
npm WARN cleanup   [
npm WARN cleanup     undefined,
npm WARN cleanup     AssertionError [ERR_ASSERTION]: rimraf: missing path
npm WARN cleanup         at rimraf (/home/circleci/project/node_modules/npm/node_modules/rimraf/rimraf.js:54:3)
npm WARN cleanup         at node:internal/util:360:7
npm WARN cleanup         at new Promise (<anonymous>)
npm WARN cleanup         at rimraf (node:internal/util:346:12)
npm WARN cleanup         at /home/circleci/project/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:532:20
npm WARN cleanup         at Array.map (<anonymous>)
npm WARN cleanup         at Arborist.[rollbackCreateSparseTree] (/home/circleci/project/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:532:8)
npm WARN cleanup         at Arborist.[reifyPackages] (/home/circleci/project/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:235:31)
npm WARN cleanup         at async Arborist.reify (/home/circleci/project/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:155:5)
npm WARN cleanup         at async Prune.exec (/home/circleci/project/node_modules/npm/lib/commands/prune.js:28:5)
npm WARN cleanup         at async module.exports (/home/circleci/project/node_modules/npm/lib/cli.js:78:5) {
npm WARN cleanup       generatedMessage: false,
npm WARN cleanup       code: 'ERR_ASSERTION',
npm WARN cleanup       actual: undefined,
npm WARN cleanup       expected: true,
npm WARN cleanup       operator: '=='
npm WARN cleanup     }
npm WARN cleanup   ]
npm WARN cleanup ]
npm ERR! process terminated
npm ERR! signal SIGHUP

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/circleci/.npm/_logs/2022-04-28T04_58_32_891Z-debug-0.log
npm WARN cleanup Failed to remove some directories [
npm WARN cleanup   [
npm WARN cleanup     undefined,
npm WARN cleanup     AssertionError [ERR_ASSERTION]: rimraf: missing path
npm WARN cleanup         at rimraf (/home/circleci/project/node_modules/npm/node_modules/rimraf/rimraf.js:54:3)
npm WARN cleanup         at node:internal/util:360:7
npm WARN cleanup         at new Promise (<anonymous>)
npm WARN cleanup         at rimraf (node:internal/util:346:12)
npm WARN cleanup         at /home/circleci/project/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:532:20
npm WARN cleanup         at Array.map (<anonymous>)
npm WARN cleanup         at Arborist.[rollbackCreateSparseTree] (/home/circleci/project/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:532:8)
npm WARN cleanup         at Arborist.[reifyPackages] (/home/circleci/project/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:235:31)
npm WARN cleanup         at async Arborist.reify (/home/circleci/project/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:155:5)
npm WARN cleanup         at async Prune.exec (/home/circleci/project/node_modules/npm/lib/commands/prune.js:28:5)
npm WARN cleanup         at async module.exports (/home/circleci/project/node_modules/npm/lib/cli.js:78:5) {
npm WARN cleanup       generatedMessage: false,
npm WARN cleanup       code: 'ERR_ASSERTION',
npm WARN cleanup       actual: undefined,
npm WARN cleanup       expected: true,
npm WARN cleanup       operator: '=='
npm WARN cleanup     }
npm WARN cleanup   ]
npm WARN cleanup ]
npm ERR! process terminated
npm ERR! signal SIGHUP

mohanraj-r · 2022-05-04T19:45:07Z

Retracing/redoing steps with npm didn't help. Exploring alt solutions in #4042

mohanraj-r added 2 commits April 27, 2022 19:28

build: switch package lock file to version 3

cbfd50a

ci: switch from node 14 to node 16

64fe2d5

mohanraj-r requested a review from a team as a code owner April 28, 2022 02:35

mohanraj-r requested a review from jeffb-sfdc April 28, 2022 02:35

mohanraj-r added 4 commits April 27, 2022 20:26

build: disable strict peerDependencies that is default in npm8

8ddafb5

to workaround build failures due to peer deps

build: refresh package lock file

24f06c3

refactor: use npm ci in reinstall script

6bbf3d0

Revert "refactor: use npm ci in reinstall script"

3e4150b

This reverts commit 6bbf3d0.

build(debug): revert to package lock version 1 to check status on build

c36791f

mohanraj-r closed this May 4, 2022

mohanraj-r deleted the mohanraj-r/node16_npm_update_take2 branch May 4, 2022 19:45

This was referenced May 9, 2022

[WIP] build: use a bundler (esbuild) along with vsce to package vsix files #4087

Closed

build: update to node v16 with npm v6 for packaging #4092

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build(salesforcedx-vscode): update node to v16 and npm v8 #4067

build(salesforcedx-vscode): update node to v16 and npm v8 #4067

mohanraj-r commented Apr 28, 2022 •

edited

Loading

mohanraj-r commented Apr 28, 2022 •

edited

Loading

mohanraj-r commented May 4, 2022

build(salesforcedx-vscode): update node to v16 and npm v8 #4067

build(salesforcedx-vscode): update node to v16 and npm v8 #4067

Conversation

mohanraj-r commented Apr 28, 2022 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

Functionality Before

Functionality After

Notes

mohanraj-r commented Apr 28, 2022 • edited Loading

mohanraj-r commented May 4, 2022

mohanraj-r commented Apr 28, 2022 •

edited

Loading

mohanraj-r commented Apr 28, 2022 •

edited

Loading