Skip to content

Commit

Permalink
Revert "test: add NUT for web server"
Browse files Browse the repository at this point in the history
This reverts commit 957126e.
  • Loading branch information
cristiand391 committed Mar 22, 2024
1 parent c6d49b2 commit 1d211dc
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 89 deletions.
39 changes: 0 additions & 39 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,6 @@ on:
workflow_dispatch:

jobs:
determine-node-versions:
outputs:
nodeVersions: ${{ steps.determine-node-versions.outputs.nodeVersions }}
runs-on: ubuntu-latest
steps:
- uses: salesforcecli/github-workflows/.github/actions/determineNodeVersions@main
id: determine-node-versions
with:
nodeVersionOverride: ${{ vars.NODE_VERSION_OVERRIDE }} # default is 'lts/*' and 'lts/-1'
yarn-lockfile-check:
uses: salesforcecli/github-workflows/.github/workflows/lockFileCheck.yml@main
# Since the Windows unit tests take much longer, we run the linux unit tests first and then run the windows unit tests in parallel with NUTs
Expand All @@ -23,36 +14,6 @@ jobs:
windows-unit-tests:
needs: linux-unit-tests
uses: salesforcecli/github-workflows/.github/workflows/unitTestsWindows.yml@main
sfdx-core-nuts:
needs: linux-unit-tests
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ fromJSON(needs.determine-node-versions.outputs.nodeVersions) }}
cache: yarn
- uses: google/wireit@setup-github-actions-caching/v1
continue-on-error: true
- name: Cache node modules
id: cache-nodemodules
uses: actions/cache@v3
env:
cache-name: cache-node-modules
with:
path: '**/node_modules'
key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/yarn.lock') }}

- uses: salesforcecli/github-workflows/.github/actions/yarnInstallWithRetries@main
if: ${{ steps.cache-nodemodules.outputs.cache-hit != 'true' }}
- run: yarn build
- name: yarn test:nuts
uses: salesforcecli/github-workflows/.github/actions/retry@main
with:
command: yarn test:nuts
env:
SF_DISABLE_TELEMETRY: true

xNuts:
needs: linux-unit-tests
uses: salesforcecli/github-workflows/.github/workflows/externalNut.yml@main
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
"prepack": "sf-prepack",
"prepare": "sf-install",
"test": "wireit",
"test:nuts": "nyc mocha test/**/*.nut.ts",
"test:only": "wireit",
"test:perf": "ts-node test/perf/logger/main.test.ts"
},
Expand Down
5 changes: 0 additions & 5 deletions src/webOAuthServer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,6 @@ export class WebOAuthServer extends AsyncCreatable<WebOAuthServer.Options> {
return this.authUrl;
}

public close(): void {
this.logger.debug('closing server connection');
this.webServer.close();
}

/**
* Executes the oauth request and creates a new AuthInfo when successful
*
Expand Down
43 changes: 0 additions & 43 deletions test/nut/webOauthServer.nut.ts

This file was deleted.

2 changes: 1 addition & 1 deletion test/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"extends": "@salesforce/dev-config/tsconfig-test-strict",
"include": ["unit/**/*.ts", "nut/**/*.ts", "perf/**/*.ts"],
"include": ["unit/**/*.ts", "perf/**/*.ts"],
"compilerOptions": {
"noEmit": true,
"skipLibCheck": true,
Expand Down

2 comments on commit 1d211dc

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: 1d211dc Previous: 6f70d6c Ratio
Child logger creation 469548 ops/sec (±2.47%) 473445 ops/sec (±0.52%) 1.01
Logging a string on root logger 785087 ops/sec (±7.57%) 786351 ops/sec (±8.32%) 1.00
Logging an object on root logger 580032 ops/sec (±8.20%) 546884 ops/sec (±7.48%) 0.94
Logging an object with a message on root logger 8480 ops/sec (±205.12%) 14276 ops/sec (±198.68%) 1.68
Logging an object with a redacted prop on root logger 473275 ops/sec (±7.34%) 416841 ops/sec (±8.16%) 0.88
Logging a nested 3-level object on root logger 365557 ops/sec (±8.83%) 357570 ops/sec (±7.30%) 0.98

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: 1d211dc Previous: 6f70d6c Ratio
Child logger creation 341327 ops/sec (±0.48%) 342158 ops/sec (±0.49%) 1.00
Logging a string on root logger 804236 ops/sec (±5.99%) 844881 ops/sec (±6.90%) 1.05
Logging an object on root logger 625554 ops/sec (±4.42%) 613653 ops/sec (±6.58%) 0.98
Logging an object with a message on root logger 6122 ops/sec (±206.53%) 5506 ops/sec (±212.77%) 0.90
Logging an object with a redacted prop on root logger 441075 ops/sec (±9.65%) 477224 ops/sec (±7.33%) 1.08
Logging a nested 3-level object on root logger 318944 ops/sec (±6.36%) 332961 ops/sec (±6.26%) 1.04

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.