fix: encrypted key regex tests will no longer be stateful #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the /g flag from the encryptedKeys regexes so that when they are tested against the properties in an auth file they will match regardless of whether they have matched a property beforehand (as is the case with /token/.test('accessToken') and /token/.test('refreshToken'))
…ICENSE.txt on Windows
RodEsp
changed the title
shetzel
approved these changes
Jun 27, 2022
mdonnalley
approved these changes
Jun 28, 2022
|
I tested without the change using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the
/gflag from theencryptedKeysregexes so that when they are tested against the properties in an auth file they will match regardless of whether they have matched a property beforehand (as is the case when'accessToken'is tested before'refreshToken'in the same auth file)Fixes forcedotcom/cli#1314
@W-11349782@