feat: save namespacePrefix in auth file #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristiand391
commented
Aug 1, 2023
| ); | ||
|
|
||
| if (namespacePrefix) { | ||
| authConfig.namespacePrefix = namespacePrefix; |
There was a problem hiding this comment.
getNamespacePrefix will return undefined if an org doesn't have a namespace prefix we just set it if there's one.
shetzel
reviewed
Aug 2, 2023
cristiand391
commented
Aug 3, 2023
| const authInfo = await AuthInfo.create({ username: testOrg.username }); | ||
| // @ts-expect-error because private method | ||
| expect(await authInfo.getNamespacePrefix(testOrg.instanceUrl, testOrg.accessToken)).to.be.undefined; | ||
| expect(authInfo.getFields().namespacePrefix).to.be.undefined; |
There was a problem hiding this comment.
this test verifies that getNamespacePrefix returns undefined instead of an empty string to ensure we never end up with namespacePrefix: "" in an auth file.
cristiand391
commented
Aug 3, 2023
| match({ | ||
| url: `${testOrg.instanceUrl}//services/data/v51.0/query?q=Select%20Namespaceprefix%20FROM%20Organization`, | ||
| }) | ||
| ) |
There was a problem hiding this comment.
use sinon matcher to only stub the namespace query:
https://sinonjs.org/releases/latest/matchers/
shetzel
approved these changes
Aug 3, 2023
|
QA: linked this branch to plugin-auth, then authed an org that had a namespace. I see it in the auth file and it's returned with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Save the namespace prefix of an org in its auth file.
When creating an instance of
AuthInfo, sfdx-core will query the namespace prefix of an org and save it asnamespacePrefix.Organizationobject:https://developer.salesforce.com/docs/atlas.en-us.object_reference.meta/object_reference/sforce_api_objects_organization.htm
What issues does this PR fix or reference?
@W-12709731@
@W-12709714@