Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use memory logger instance when disabled #979

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented Nov 7, 2023

What does this PR do?

use a memory logger when disabled

What issues does this PR fix or reference?

@W-14424066@
forcedotcom/cli#2553

@WillieRuemmele
Copy link
Member

WillieRuemmele commented Nov 8, 2023

QA Notes


 ➜  ls ~/.sf/ | grep sf-
➜  plugin-settings git:(main) 🔗1
 ➜  ./bin/dev.js config:list --global
List Config
==========================================
| Name                     Location Value  
| ──────────────────────── ──────── ────── 
| disable-telemetry        Global   true   
| org-metadata-rest-deploy Global   true   
| target-dev-hub           Global   DevHub 
➜  plugin-settings git:(main) 🔗1
 ➜  ls ~/.sf/ | grep sf-
sf-2023-11-08.log
➜  plugin-settings git:(main) 🔗1
 ➜  rm -rf ~/.sf/sf-2023-11-0*
➜  plugin-settings git:(main) 🔗1
 ➜  SFDX_DISABLE_LOG_FILE=true ./bin/dev.js config:list --global
List Config
==========================================
| Name                     Location Value  
| ──────────────────────── ──────── ────── 
| disable-telemetry        Global   true   
| org-metadata-rest-deploy Global   true   
| target-dev-hub           Global   DevHub 
➜  plugin-settings git:(main) 🔗1
 ➜  ls ~/.sf/ | grep sf-
➜  plugin-settings git:(main) 🔗1

✅ : see no logs, run without env, see log, delete log, run WITH SFDX env, no log
✅ : see no logs, run without env, see log, delete log, run WITH SF env, no log
✅ : still logs to console with DEBUG=*

@WillieRuemmele WillieRuemmele merged commit a62834c into main Nov 8, 2023
39 checks passed
@WillieRuemmele WillieRuemmele deleted the sh/no-logger-creation-with-env-var branch November 8, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants