Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sm/handle http error responses #980

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Nov 9, 2023

What does this PR do?

this does NOT require the corresponding jsforce change to be merged, and should work with no changes to jsforce
jsforce/jsforce#1376

handles html responses from expired/deleted orgs where the 420 error page is now present
https://computing-connect-6970-dev-ed.scratch.my.salesforce.com/services/data/v50.0

before
Screenshot 2023-11-09 at 9 42 59 AM

after
Screenshot 2023-11-09 at 9 54 21 AM

QA:
create org
delete org
sf org open -o deletedOrg

What issues does this PR fix or reference?

@W-14454889@

@WillieRuemmele
Copy link
Member

QA Notes


before:
attempting to open a deleted SO

 ➜  sf org open -o [email protected]                  
Error (1): <!DOCTYPE HTML>
<html lang=en-US>
<head>
<meta charset=UTF-8>
<title>Error Page</title>
    <style>
        /*! normalize.css v3.0.2 | MIT License | git.io/normalize */
...

after:

 ➜  ../../oss/plugin-org/bin/run.js org:open -o [email protected]                              
Error (1): Unexpected response from the platform

Try this:

Check that the instance URL is correct and the org still exists. https://data-java-9301-dev-ed.scratch.my.salesforce.com/services/data/v50.0
See what's at the URL that's causing the problem: https://data-java-9301-dev-ed.scratch.my.salesforce.com/services/data/v50.0.

@WillieRuemmele WillieRuemmele merged commit baac2df into main Nov 10, 2023
35 of 37 checks passed
@WillieRuemmele WillieRuemmele deleted the sm/handle-http-error-responses branch November 10, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants