Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle string replacements for individual custom labels #1257

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented Mar 15, 2024

What does this PR do?

When individual CustomLabel metadata with string replacements are targeted for a deploy without the parent CustomLabels metadata, the string replacement won't occur due to the code using cached file content. This PR sets replacements on a parent component when the child has string replacements.

CustomLabel String replacement not working correctly with --manifest flag
@W-15262083@

@shetzel shetzel marked this pull request as ready for review March 19, 2024 18:25
@shetzel shetzel requested a review from a team as a code owner March 19, 2024 18:25
@mshanemc mshanemc merged commit 70571e8 into main Mar 19, 2024
68 checks passed
@mshanemc mshanemc deleted the sh/custom-label-string-replace branch March 19, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants