-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom label beta 2 #1392
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
after beta feedback forcedotcom/cli#2840 and discussion forcedotcom/cli#2948, update the way labels decompose.
Meta
CustomLabels
andCustomLabel
both use the default Adapter (no change) and can stand alone as SourceComponents. There is no relationship between them, except for the output of the TransformersCustomLabel
is always used for source format (1 file per label)CustomLabels
is always uses for metadata format (1 file with all the labels in it. namedCustomLabels
)toSourceFormat
needs the entire mergeSet (and not a singlemergeWith
SourceComponent) to find components with the matching fullName (for labels outside the default dir, to avoid creating duplicates).change the decomposeCustomLabelsBeta to do one file per label (preset update)
""
for suffix/childTypes/strictDirs to remove an entry from the default registry (this preset removes the parent/child relationship between label/labels)other
QA notes
there are some small changes in STL necessary to make this behave right forcedotcom/source-tracking#651 and you'll need those for testing tracking.
Tested during development
/labels
folder in source format (deploy, retrieve using -m CustomLabel:foo)/labels
directory for grouping labels (deploy, retrieve changes)--metadata CustomLabels
("give me all of them") doesn't match the local CustomLabel and put them in the right places (they'll all end up in the default directory). Workaround--metadata CustomLabel
(using--metadata CustomLabels
now throws an error when the new Transformer is used).What issues does this PR fix or reference?
@W-16375268@