Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A small refactoring #235

Merged
merged 3 commits into from
Oct 20, 2020
Merged

A small refactoring #235

merged 3 commits into from
Oct 20, 2020

Conversation

RomanPodymov
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Hello.
Thank you for DEV-ios.
I did a small refactoring in MediaManager.swift.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

chickdan
chickdan suggested changes Oct 17, 2020
View reviewed changes
Copy link
Contributor

@chickdan chickdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Roman, thanks for submitting this PR! If you remove the static keyword from seekInterval then you won't need to use Self when referencing that variable. Since the variable isn't used anywhere else I don't see a need for it to be static.

DEV-Simple/core/MediaManager.swift Outdated Show resolved Hide resolved
fdocr
fdocr approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@fdocr fdocr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @RomanPodymov

@fdocr fdocr merged commit 6704f15 into forem:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chickdan chickdan chickdan requested changes

@fdocr fdocr fdocr approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RomanPodymov @CLAassistant @fdocr @chickdan